Quality

• http://www.phpthewrongway.com/
• https://thephpleague.com/#quality

Minimum PHP Version

• https://make.wordpress.org/core/2018/12/08/updating-the-minimum-php-version/
• https://make.wordpress.org/core/2019/03/26/coding-standards-updates-for-php-5-6/

PHPLint

https://github.com/overtrue/phplint

xmllint

We use xmllint to lint XML files.

brew install xmlstarlet

• http://xmlsoft.org/xmllint.html
• https://github.com/jrfnl/QA-WP-Projects/blob/9fcb24fcac54d376a80515fb9da79e99eb420551/.travis.yml

ESLint

We use ESLint to lint JavaScript and JSON files.

• https://github.com/wp-pay-gateways/omnikassa-2/blob/develop/package.json#L34-L40
• https://github.com/wp-pay-gateways/omnikassa-2/blob/develop/.travis.yml#L91-L92

JSON (JavaScript Object Notation)

A lot of payment providers use JSON driven API’s. Also in WordPress and the WordPress Pay library jSON is used very often. WordPress and PHP JSON functions are used very often. Since we increased the minimal PHP version to 5.6 (or higher) we also start to use JsonSerializable::jsonSerialize.

• https://www.json.org/
• https://www.php.net/manual/en/jsonserializable.jsonserialize.php

No ‘lock’ files in libraries

https://blog.martinhujer.cz/17-tips-for-using-composer-efficiently/

WordPress Coding Standards

https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards

Neutron PHP Standard

https://github.com/Automattic/phpcs-neutron-standard

Slevomat Coding Standard

https://github.com/slevomat/coding-standard

PHP – Name resolution rules – Fully Qualified names (FQN)

In the WordPress Pay library we will try to use Fully Qualified names (FQN) to take full advantage of PHP opcode. The “Slevomat Coding Standard” library can be used to check on this.

• https://www.remcotolsma.nl/2019/09/php-namespaces-use-of-prefix/

Symfony Security Check

• https://github.com/FriendsOfPHP/security-advisories
• https://github.com/sensiolabs/security-checker
• https://symfony.com/download

Exclude non-essential files in .gitattributes.

• https://thephpleague.com/#quality
• https://php.watch/articles/composer-gitattributes

Avoid too many static methods

• https://wpshout.com/courses/object-oriented-php-for-wordpress-developers/php-static-methods-in-depth/
• https://stackoverflow.com/questions/47118926/should-i-avoid-using-too-many-static-methods-in-php
• https://codeburst.io/static-classes-are-evil-or-make-your-dependencies-explicit-af3e73bd29dd
• http://verraes.net/2014/06/when-to-use-static-methods-in-php/

PHPLOC

phploc is a tool for quickly measuring the size and analyzing the structure of a PHP project.

https://github.com/sebastianbergmann/phploc

Composer bin plugin — Isolate your bin dependencies

composer require --dev bamarni/composer-bin-plugin

composer bin phpstan require --dev phpstan/phpstan

composer bin psalm require --dev vimeo/psalm

.gitignore

# Composer bin plugin
/vendor-bin/**/vendor